Fallenbagel / jellyseerr

Fork of overseerr for jellyfin support.
https://docs.jellyseerr.dev/
MIT License
3.75k stars 231 forks source link

Gotify Priority Notification #562

Open levogevo opened 11 months ago

levogevo commented 11 months ago

Description

Gotify notifications have a priority setting that allow for control over visibility

Jellyseerr currently does not show an option for changing the priority of gotify notifications and defaults to 0.

2023-11-10 19:54:59.192 INFO: WebSocket(272): received message 
{"id":2497,"appid":2,"message":"Check check, 1, 2, 3. Are we coming in clear?",
"title":"Test Notification","priority":0,"extras":{"client::display"
:{"contentType":"text/markdown"}},"date":"2023-11-11T01:54:59.344171175Z"}

in gotify.ts

private getNotificationPayload(
    type: Notification,
    payload: NotificationPayload
  ): GotifyPayload {
    const { applicationUrl, applicationTitle } = getSettings().main;
    let priority = 0;

Desired Behavior

Add priority as a user configurable number in the gotify sections in the notifications page.

Additional Context

image

"Priority" input here

Code of Conduct

moltra commented 3 months ago

please assign to me

Fallenbagel commented 3 months ago

please assign to me

You're more than welcome to open a pr for this c:

Clankcoll commented 2 weeks ago

were you able to accomplish this ?

Kinda needy to be honest this would be an sexy addition to the whole Notification gang!