Jellyseerr is adding the wrong user to tagged requests in sonarr and radarr

Fallenbagel / jellyseerr

Fork of overseerr for jellyfin support.

https://docs.jellyseerr.dev/

MIT License

3.95k stars 250 forks source link

Jellyseerr is adding the wrong user to tagged requests in sonarr and radarr #652

Closed douglasparker closed 9 months ago

douglasparker commented 9 months ago

Description

Jellyseerr seems to be adding the wrong user as a tag to requested media in radarr and sonarr.

The user is correct in Jellyseerr and when notifications are sent, however the tag for the media is another user.

My (default user) tags are fine. Users are created automatically when they first login to jellyseerr using their Emby accounts.

Version

1.7.0

Steps to Reproduce

Make sure the tag requests option is ticked for sonarr and radarr.
Add multiple users excluding the default admin user.
Request media using an account that has logged in via Emby (not the main account)
Login to sonarr or radarr and check the tag and see that it belongs to another user.

Screenshots

Logs

No response

Platform

desktop

Device

Windows

Operating System

Windows 11 Pro

Browser

Chrome

Additional Context

No response

Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

Fallenbagel commented 9 months ago

Can you try the develop tag?

douglasparker commented 9 months ago

Can you try the develop tag?

Unfortunately, I can’t test the develop tag because I am using preview-postgres.

Fallenbagel commented 9 months ago

Can you try the develop tag?

Unfortunately, I can’t test the develop tag because I am using preview-postgres.

Ah then I cant help. This could be an issue with that tag

douglasparker commented 9 months ago

Can you try the develop tag?

Unfortunately, I can’t test the develop tag because I am using preview-postgres.

Ah then I cant help. This could be an issue with that tag

Okay, let’s keep this issue open and I will test again after preview-postgres gets merged into develop.

dr-carrot commented 9 months ago

@douglasparker I can't seem to repro it from fresh installs of sonarr/radarr/jellyseerr. From my investigation, the code is checking for a tag with the prefix: this.requestedBy.id + ' - '. If an existing tag exists with the same id but the wrong user, jellyseerr won't correct it or make a new one. Try deleting the tag from sonarr/radarr or updating the name (would require running an update against the *arr db). Did you migrate to postgres from sqlite, or is it a fresh install?

douglasparker commented 9 months ago

@douglasparker I can't seem to repro it from fresh installs of sonarr/radarr/jellyseerr. From my investigation, the code is checking for a tag with the prefix: this.requestedBy.id + ' - '. If an existing tag exists with the same id but the wrong user, jellyseerr won't correct it or make a new one. Try deleting the tag from sonarr/radarr or updating the name (would require running an update against the *arr db). Did you migrate to postgres from sqlite, or is it a fresh install?

This is a fresh install of Jellyseerr, but I am using the same instance of Sonarr and Radarr from when I was using this feature in Overseerr.

I will delete all the tags and hopefully that should clear it up!

Edit: It looks like the issue was related to new users having different IDs for the fresh install of Jellyseerr. I thought it would just create new tags when it saw ID: Username didn't exist.

I've cleared all tags and things should be good now.

Hopefully we can now get #628 merged!