search

Fallenbagel / jellyseerr

Fork of overseerr for jellyfin support.
https://docs.jellyseerr.dev/
MIT License
3.75k stars 231 forks source link

Support monitor type for Radarr #695

Open RoboMagus opened 7 months ago

RoboMagus commented 7 months ago

Description

Mostly an extension of #191, and related to #325.

I'd like to browse and discover content that seems interesting on Jellyseerr and if it seems worthy to watch add it to my 'backlog' but not necessarily start monitoring. Having a selection if a movie should be monitored or not be presented to at least the approving user (admin) would be a nice addition to prevent the library filling up with content that wouldn't be watched for a long time.

Desired Behavior

Have the option as the admin user to select as which monitoring mode the movie should be added to Radarr.

Additional Context

No response

Code of Conduct

bonswouar commented 6 months ago

Another use case (which feels almost like a bug to me): I have some content automatically added (and monitored) in Radarr from imports lists. They are then shown as "requested" in Jellyseerr. Sometimes I un-monitor some of those from Radarr, and (I guess) because I don't delete them from Radarr they can't be requested anymore from Jellyseerr - they are still shown as "requested".

Supporting the Monitor status from Radarr could give the option to any user (permissions could be nice) to "monitor/download now" a movie already present in Radarr but not monitored.

Fallenbagel commented 6 months ago

Another use case (which feels almost like a bug to me): I have some content automatically added (and monitored) in Radarr from imports lists. They are then shown as "requested" in Jellyseerr. Sometimes I un-monitor some of those from Radarr, and (I guess) because I don't delete them from Radarr they can't be requested anymore from Jellyseerr - they are still shown as "requested".

if you have the movie available and its not showing as available, thats a configuration issue. If the movie is added to radarr and it shows as requested, whether you unmonitor or not movies still ADDED to radarr. Not a bug. What jellyseerr does is add the items to *arr. Its not for triggering searches After its added.

bonswouar commented 6 months ago

if you have the movie available and its not showing as available, thats a configuration issue. If the movie is added to radarr and it shows as requested, whether you unmonitor or not movies still ADDED to radarr.

Not sure I follow. The movie isn't available, it's only present in Radarr movie list, but not monitored (on purpose). The monitoring status is already partially handled as when a movie is initially added to Radarr but not monitored, it won't be added to Jellyseerr (thus won't be shown as "requested").

Not a bug. What jellyseerr does is add the items to *arr. Its not for triggering searches After its added.

I just mean that supporting the Monitoring status in Jellyseerr would be coherent with Radarr's actual behaviour: a movie not monitored in Radarr will never be available, and will always be shown as "requested" in Jellyseerr, with no indication for the user that's it's not monitored, and no action possible.

EDIT: For context, I have some "unwanted" movies added to Radarr (and monitored) from auto import lists (following actors and such), so I often manually unmonitor some. I feel like that's a pretty typical use case (how would you manage import lists otherwise?). But those movies still appear as requested in JellySeerr, that's misleading for the user as he has no idea this movie isn't monitored. If you still feel like that's not a bug and it shouldn't be handled by JellySeerr, I'm open to any suggestion/workaround!

bonswouar commented 5 months ago

@Fallenbagel I took a quick look at the code, an easy first implementation could be during the execution of radarr scanner: Instead of skipping if !radarrMovie.monitored, we could just delete the movie from Jellyseerr (if present, and if its status was "UNKNOWN" to prevent removing available movies) Or we could change its status? But that would mean adding a new one - although replacing "UNKNOWN" with something like "MONITORED" and "NOT_MONITORED" could be nice.

At least Jellyseerr users will be able to see when a movie won't be automatically downloaded (without adding much complexity), and should be able to request them again (the same way they can already request movies that have been added to Radarr but never monitored). Does it make sense for you?