Fallenbagel / jellyseerr

Fork of overseerr for jellyfin support.
https://docs.jellyseerr.dev/
MIT License
3.75k stars 231 forks source link

UI doesn't consider "Local Sign-In" when disabled for certain features #825

Closed Jacouille closed 2 months ago

Jacouille commented 4 months ago

Description

Some features in the UI do not consider the "Local Sign-In" settings when it is disabled.

Version

1.9.2

Steps to Reproduce

  1. Go to the Jellyseerr setting page in the users tab (/settings/users)
  2. Disable the "Local Sign-In" setting and save your changes
  3. View the issues described in the description section above behave like the setting is still enabled

Screenshots

No response

Logs

No response

Platform

desktop

Device

all

Operating System

all

Browser

all

Additional Context

No response

Code of Conduct

Fallenbagel commented 4 months ago
  1. Whether you disable local sign in or not, every account is both. Every jellyfin user also is a local account. It's linked

  2. Email will be required. We will remove the validation so Email can be jellyfin username/email (it was supposed to be this way but accidental)

  3. Refer back to 1. Every user is still a local user (it's all interlinked) which is why we don't hide these settings

gauthier-th commented 2 months ago

Should be fixed by #900