Fallenbagel / jellyseerr

Fork of overseerr for jellyfin support.
https://docs.jellyseerr.dev/
MIT License
3.51k stars 218 forks source link

users require e-mail adress even though "Require user email" is disabled #963

Closed Wurzelmann closed 1 week ago

Wurzelmann commented 1 week ago

Description

I imported my users directly from Jellyfin via the Users menu, which worked perfectly, but every user has their username automatically filled as e-mail address in their user settings. I do not know if this has been like this since importing (more than a year ago), but I cannot delete those user names from the e-mail field without jellyseerr complaining

Email required even though the setting Require user email (Settings->Notifications->Email) is disabled and not checked.

My only options at this point are:

  1. replace all those usernames in the e-mail field with actual e-mail addresses
  2. ignore it (which seems to lead to problems when logging users in from new devices, since jellyseerr expects them to use an e-mail address, which they do not have with their account, and never needed before)

Version

1.9.2

Steps to Reproduce

  1. import Jellyfin users via Users -> Import Jellyfin Users
  2. klick Edit on a user without e-mail address
  3. notice how jellyseer automatically copied their Display Name to the Email field
  4. try to clear the Email field
  5. jellyseerr complains with "Email required"

Screenshots

Screenshot_2024-09-07_16-42-46_jellyseer_require_user_mail_disabled Screenshot_2024-09-07_16-41-13_jellyseer_email_required

Logs

No response

Platform

desktop

Device

Desktop, laptops

Operating System

Debian 12.7, Windows 10

Browser

Firefox, Chrome

Additional Context

No response

Code of Conduct

Fallenbagel commented 1 week ago

The require email button is not for that. The email field in the profile has to be something. The reason why their usernames get copied is because of that. That is whats used for local logins. That field cannot be empty

Wurzelmann commented 1 week ago

Okay, so the copied username is a placeholder for the login then if it's a Jellyfin and not a local user, if I understood that correctly?

Fallenbagel commented 1 week ago

Okay, so the copied username is a placeholder for the login then if it's a Jellyfin and not a local user, if I understood that correctly?

Each user has two login types. Authentication through jellyfin and jellyseerr. Jellyfin authentication is handled by jellyfin. Jellyseerr login form has jellyseerr handling the authentication using the email & password. The problem we face when it comesnto jellyfin is, none or the users have an email as jellyfin doesn't use it. So we use usernames as emails. Now the issue comes when you want to use smtp, ofc these usernames aren't actually emails right? That's what the require emails button checkbox is for.

Now the other issue was this was causing a lot of users to get confused by what that field really does (like this issue) so we have now removed the display of that field on a users perspective and only handle it server wide (https://github.com/Fallenbagel/jellyseerr/pull/900)

So now in a user's perspective, that field will be empty if it's not an email that was provided but it will still be using the username just not displayed to save confusion.

Fallenbagel commented 1 week ago

Just closing the issue as this issue is not really relevant anymore as described above ^

Wurzelmann commented 1 week ago

Ah, I see, thank you for explaining this. I just wanted to close it, thank you.