FallingColors / HexMod

Minecraft mod about drawing spells
MIT License
133 stars 88 forks source link

[1.0 Preview] Players & Monsters are missing support for findDataHolder() #278

Open KirinDave opened 2 years ago

KirinDave commented 2 years ago

Chronicler's Purification and Chronicler's Gambit do not treat players or monsters holding focuses, scrolls or spellbooks as valid entity targets, and this seems like a real missed opportunity for an extremely funny, fun, and subtle aspect of Hexcasting.

This is entirely consistent with the letter and intent of these features. It will also add an extra and very subtle step to PvP. It will also make spell sharing/stealing (which we might even all soft pvp?) viable. It will also further reinforce the value of write-once cypher sharing as a way of protecting property.

It also supports some extremely weird and fun automation ideas, like having a booth that copies spellbooks between players in a redstone controlled way.

Please consider making these valid targets for Chronicler's.

gamma-delta commented 2 years ago

i hate this idea and you but god dammit if i don't want to impl it

yrsegal commented 2 years ago

would be pretty simple to attach them in the same way scrolls and such get the cap attached