search

FallingColors / HexMod

Minecraft mod about drawing spells
MIT License
123 stars 87 forks source link

Debug media cube is broken in pre-620 #640

Open Twisted-Code opened 6 months ago

Twisted-Code commented 6 months ago

Modloader

Fabric

Minecraft version

1.20.1

Hex Casting version

0.11.1-7-pre-620

Modloader version

Fabric: 0.1|.6 + API 0.91.0+ 1.20.1

Modpack info

https://github.com/walksanatora/HexxyTestPack

The latest.log file

https://mclo.gs/nvZYHdD

Issue description

Despite my expectation, having a media cube renamed to "debug patterns" does not seem to do anything.

Steps to reproduce

  1. Load a creative world
  2. spawn a media cube
  3. rename the media cube "Debug Patterns" (any capitalization, last I checked, should work)
  4. draw some patterns
  5. nothing appears in chat, unlike on 1.19.2

Other information

2024-03-26_08 10 52

Twisted-Code commented 6 months ago

the name I gave the media cube was enough for it to start doing the enchanted glow effect, so I must've done something right. It's just not working completely?

object-Object commented 6 months ago

@macks2008 Can you check if "debug media" works?

Probably related:

https://github.com/FallingColors/HexMod/blob/65a07575137282a14e528045de0ddd7663e6d95a/Common/src/main/java/at/petrak/hexcasting/common/items/magic/ItemCreativeUnlocker.java#L42

I don't see any usages of this variable. Guessing it got accidentally refactored into the void at some point.

Twisted-Code commented 6 months ago

what is debug media supposed to do? it didn't seem to do anything when I drew ol' Ray Caste image

object-Object commented 6 months ago

make sure you're using it in survival - it's supposed to print all media usage drawn from the cube, so being in creative or having other sources messes with it

Twisted-Code commented 6 months ago

Okay it does work in survival. So it's just debug patterns that's not working, as far as I can tell.

object-Object commented 6 months ago

great, thanks for confirming. I think it should be an easy fix then - hopefully just re-add the code that was removed. prioritizing as medium because hex is hard enough to use even without the limited debug features being broken.

Twisted-Code commented 6 months ago

🥳

gamma-delta commented 5 months ago

I removed the code while I was refactoring the evaluator because I didn't actually know it was there (Wire added it without telling me) so I didn't know how it worked.

Twisted-Code commented 3 months ago

ah... whoops. That reminds me of a joke about code documentation, "when I wrote this code, only God and I knew what it did. Now only God knows". (Side note: what is Wire? Is that an IDE or gradle plugin or something?) Anyway, just wanted to check in: Has any progress been made to fix this? I was starting to set up my development world for "HexxyTest S2" and noticed this feature isn't yet fixed on whatever version we are using.

object-Object commented 3 months ago

wiresegal, former hex contributor afaik no progress has been made; we'll close this issue when it's fixed on main