search

FallingColors / HexMod

Minecraft mod about drawing spells
MIT License
122 stars 87 forks source link

Fix #647 - undefined translation strings #724

Closed navarchus closed 1 month ago

navarchus commented 1 month ago

Fix for #647

  1. "death.attack.hexcasting.overcast.player" was missing, added missing string in en_us, still needs to be defined in ru_ru and zh_cn. Verified works (1.20.1, forge-47.1.47).

  2. changed stat.hexcasting.media_overcasted to stat.hexcasting.media_overcast in en_us, ru_ru, and zh_cn. Verified works (1.20.1, forge-47.1.47).

  3. was fixed before this PR. Verified works (1.20.1, forge-47.1.47).

object-Object commented 1 month ago

Datagen shouldn't need to be run for this change btw. The build was failing due to an intermittent ForgeGradle issue (which should be mitigated by #696).

object-Object commented 1 month ago

image image image

cool cool - thanks for the PR