FallingColors / HexMod

Minecraft mod about drawing spells
MIT License
134 stars 88 forks source link

Allow spell circles to access player inventory #734

Closed vgskye closed 1 week ago

vgskye commented 2 months ago

fixes #638

SamsTheNerd commented 2 months ago

this code looks basically copy pasted from the player casting env, maybe it should just be abstracted into a shared method somewhere?

vgskye commented 2 months ago

it is based off of that, but there are some behavioural changes(e.g. pull mainhand first then offhand, rather than other-hand-first or other-hand-only since spell circles are hands-free) that I'm not sure makes sense to unify into one set of methods