search

FallingColors / HexMod

Minecraft mod about drawing spells
MIT License
122 stars 87 forks source link

Add option to have click toggle drawing instead of dragging #735

Closed vgskye closed 3 weeks ago

vgskye commented 1 month ago

closes #357. confirmed working on fabric, forge should probably work

vgskye commented 1 month ago

tested and working on forge as well

object-Object commented 1 month ago

We should probably also add a localization to the lang file for this cloth config entry. see here:

https://github.com/FallingColors/HexMod/blob/f3f9d0740bda6df22826c18780e0241500983e6b/Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5#L286-L303

vgskye commented 1 month ago

We should probably also add a localization to the lang file for this cloth config entry.

I feel like this can be batched with #729?

object-Object commented 1 month ago

i don't see any reason to? just because other options didn't get localizations doesn't mean we should continue not adding them for new ones. imo the localizations for a given feature should be added in the PR where the feature itself is added when possible.

vgskye commented 1 month ago

fair, lemme add that after a rebase

gamma-delta commented 3 weeks ago

If it's tested and confirmed working it LGTM.

vgskye commented 3 weeks ago

why the fuck is hexdoc failing I didn't even touch anything doc-related

gamma-delta commented 3 weeks ago

The hexdoc issue was fixed https://github.com/hexdoc-dev/hexdoc/commit/9e1025c13a1f552d34cd7885471edb34fb821e63 so hopefully that should pass now

gamma-delta commented 3 weeks ago

Oh my god Github

gamma-delta commented 3 weeks ago

We should probably document this at some point but again not something I care to block on.