search

FallingColors / HexMod

Minecraft mod about drawing spells
MIT License
122 stars 87 forks source link

Document Media Cube #743

Closed navarchus closed 1 day ago

navarchus commented 1 month ago

Fixes #390 Add hidden entry in book gated by advancement. Explains function of Media Cube once it has been put into Player's inventory.

object-Object commented 4 weeks ago

something seems messed up with the commits - there are some commits on this branch that are also on main but with a different SHA.

navarchus commented 4 weeks ago

something seems messed up with the commits - there are some commits on this branch that are also on main but with a different SHA.

I did a force push to revert an unnecessary commit, should I just open a new PR?

object-Object commented 4 weeks ago

you can if you want, or you could fix it with rebase, or I can probably fix it if I get a chance

navarchus commented 4 weeks ago

you can if you want, or you could fix it with rebase, or I can probably fix it if I get a chance

I'll give it a shot tomorrow

gamma-delta commented 3 weeks ago

I feel like if we're documenting the media cube we should probably document the stuff it does (does it still have the thing where it displays all the patterns executed based on the anvil rename?)

object-Object commented 3 weeks ago

debug patterns still works, but debug media doesn't (#640)

gamma-delta commented 3 weeks ago

Again this is something I'd rather not block the release on. Hexdebug is a way better debugger anyways.

gamma-delta commented 3 weeks ago

For the non-tracing things, I think the tooltip explains what it does just fine.

object-Object commented 3 weeks ago

mmm, yeah. the point of #390 was specifically to document those hidden features accessible by renaming the item.

navarchus commented 3 weeks ago

I can take a second pass at this and redo the documentation sometime this week if that's necessary.