search

Fallman2 / pe

0 stars 0 forks source link

List-s command executed whenever any schedule is edited #3

Open Fallman2 opened 11 months ago

Fallman2 commented 11 months ago

When the edit-s command is used, the list of schedules returns to display all schedules even after list-s m/0 is used previously to only see all missed schedules.

Steps to reproduce: Have some schedules be missed and others be marked as completed. Then use the list-s m/0 command to look for all schedules marked missed. Then edit a schedule.

Command inputs: list-s edit-s 1 st/2023-09-15T08:58

image.png

image.png

nus-pe-script commented 11 months ago

Team's Response

Maintaining this behaviour from AB-3 was a design choice.

The most important thing to show the user after an edit schedule command is the edited schedule. Edits made to the schedule might result in the schedule being no longer displayed as part of the filtered schedules (by status, assigned tutor etc).

Users may find this behaviour undesirable as they are unsure whether the edit was successfully made. Clearing the filter and listing all schedules after all edits is the only sure way of ensuring this behaviour (that the edited schedule is shown).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As stated, the most important thing to show the user after an edit schedule command is the edited schedule. This can be seen in the provided screenshot where details of the edited schedule are displayed in the output text box after the command is executed. Additionally, as seen from the screenshots, the schedule changes positions as a result of the filter having been cleared as a result. When testing this command for the first few times, it took me some time to locate the edited schedule after edits were made. This was especially apparent when there are 10 or more schedules stored in the app. Having the filter remain even after edits would allow the user to at least still see the edited schedule some of the time.

Additionally, having the filter remain after edit would allow edits to be made more quickly. For example, if I wanted to check and edit all schedules for a specific tutor, I would have to apply the filter using the find-s command after every edit to look for each individual schedule. This can also be considered to be a design aspect that can be analyzed in the DG but there were no such design aspect considerations for the find commands for both the schedules and the tutors. While I could think that this bug could be considered NotInScope for v1.4 of this app, I would have to disagree with the decision to reject this bug.