FalsePattern / FalseTweaks

Multithreaded rendering plus a large collection of improvements, fixes, optimizations and additions to 1.7.10 clients.
https://falsepattern.com/mc
Other
57 stars 6 forks source link

TEXTURE_OPTIMIZATIONS striping issue #112

Open DarianLStephens opened 1 year ago

DarianLStephens commented 1 year ago

I'm not sure if this is a mod interaction or what, but with specifically this option enabled, I see this: 2023-05-21_15 22 26 When I turn it off, it's normal: 2023-05-21_15 23 53

DarianLStephens commented 1 year ago

Seems to happen with most any mod installed. Tested with Botania and Thaumcraft separately, and Botania made the Gravel have the lines, while Thaumcraft + Botania made Sand have the lines. The weirdness makes me suspect something bigger is going on, unrelated to the actual mods, so for now I'll just leave that option off despite of the performance it brings, same with the Item Voxellizer problem reported in my other issue.

FalsePattern commented 1 year ago

This is a known buggy interaction between anisotropic filtering and mipmaps that gets exaggerated by the packing algorithm. If you set anisotropic filtering to 0, it should stop.

DarianLStephens commented 1 year ago

That's the weird thing, though... I do have Anisotropic Filtering disabled! And it doesn't show up with FalseTweaks itself, or even vanilla, I need to add some other mods to the mix. Unless that part's because there are more textures, and it's all being packed in to a single atlas or something?

DarianLStephens commented 1 year ago

Proof or something: 2023-05-23_22 21 52 2023-05-23_22 21 54

FalsePattern commented 1 year ago

Does it also happen with mipmaps set to 0?

DarianLStephens commented 1 year ago

Nope, but man does the game look bad: 2023-05-23_22 24 02 2023-05-23_22 24 19

I've also only seen Anisotropic Filtering cause problems with animated textures, never static. This is a new thing. Though it would be nice if AF could be fixed, because it does make stuff look a lot better. I live without because of the water thing, but if it could... I dunno, ignore water and other animated textures, at least? It would be appreciated.

DarianLStephens commented 1 year ago

Huh, as an experiment, this is what it looks like with maxed-out Mipmaps and Anisotropic Filtering: 2023-05-23_22 26 17 I don't know if that says anything, but it's there! The greyness on terrain is something I've never seen before back when I used Anisotropic Filtering more.

And here's Mipmaps + Anisotropic Filtering with FalseTweaks' TEXTURE_OPTIMIZATIONS disabled again: 2023-05-23_22 28 27

DarianLStephens commented 1 year ago

For the heck of it, I also loaded up Vanilla 1.7.10 to test Anisotropic Filtering, and the incorrect color-change is there, too! 2023-05-23_22 31 11 But it's only visible on higher render distances, which explains why I never noticed it before since I used to always play on 8.

DarianLStephens commented 10 months ago

Found that the lines also seem to be fixed with 'MIPMAP_FIX' disabled. How unusual.

AxolotlAccount commented 1 week ago

Disabling MIPMAP_FIX from falsetweaks.cfg and disabling Anisotrophic Filtering from OptiFine options fixed the issue for me.