Chunks flickering with threaded rendering

[FalsePattern]

Please report any cases of chunks flickering around the player here!

[Omgise]

https://www.dropbox.com/scl/fi/bpbxsc54aheab7w8c00ep/Jdk-2023.11.25-08.54.49.01.mp4?rlkey=a7teu2t1p1hnhja7va4kvmknh&dl=0

[FalsePattern]

Update: Unfortunately i could not figure out what was causing this bug even after several days of debugging, so it's going to stay for the time being.

[Darek505]

I don’t know if it’s necessary or not, but 2.7.0:

https://github.com/FalsePattern/FalseTweaks/assets/122032896/24dd873c-29a3-4b1c-ae49-b5d70a402660

[FalsePattern]

Please also share the exact modlist you have along with any active shaderpacks, i'm trying to pinpoint the source of this bug as it never happens to me in a clean instance with forge + mixins + fplib + falsetweaks

[Darek505]

1) Updated: this was not fastcraft, as I expected, it only increases the chance of this error appearing, and so, this can be reproduced even with one falsetweaks (+ dependencies).

• method 1: 1) Install falsetweaks,falsepatternlib,unimixins 2) Create a super flat world, and start exploding TNT, there's a great chance you'll see this: https://www.veed.io/view/722ccb2b-cac2-4de1-92a5-ffbcceb9bee3?sharingWidget=true&panel=share (I had to upload it to this site again, because git does not allow me to upload videos larger than 10 MB)

• method 2: 1) Install falsetweaks,falsepatternlib,unimixins,et futurum requiem. 2) Create a super flat world -> customize -> presets -> 2;46,12,70;1; 3) Enable flight 4) /tp @ ~ 2.224 ~ 5) Start flying forward, and press the run key (ctrl by default). During this, you can notice how the chunks flicker around you:

https://github.com/FalsePattern/FalseTweaks/assets/122032896/e84ffc51-da2f-4c73-9cb4-46605a67f18d

This all related to block updating. Also, noticed that this can be fixed if B:DISABLE_BLOCKING_CHUNK_UPDATES=true

---

2) However, I noticed that 1 chunk was not rendering (without fastcraft** ), and I was able to fix this by destroying the block in this chunk:

https://github.com/FalsePattern/FalseTweaks/assets/122032896/502d1dd6-935f-4c88-9507-09cb8c976290

+ Also, was able to reproduce only with FalseTweaks + FalsePatternLib + unimixins:

https://github.com/FalsePattern/FalseTweaks/assets/122032896/3fca8371-be98-411c-8bc8-35a3fb3ad344

** - Mod list

[Omgise]

https://github.com/FalsePattern/FalseTweaks/assets/106000018/3ba15654-a9fe-4568-b404-347bff95cf7e

[FalsePattern]

Progress update, i think i have an idea what might be causing this bug, i'm working on making a test release with some of the more aggressive optimizations disabled, I will upload the file here in a few hours.

[FalsePattern]

@Darek505 I've created an experimental build from the latest commit (d0550b1): https://mvn.falsepattern.com/releases/com/falsepattern/falsetweaks-mc1.7.10/2.7.0-2-gd0550b1/falsetweaks-mc1.7.10-2.7.0-2-gd0550b1.jar

Please check if the flicker still happens on this version

[Omgise]

This version still flickers

https://github.com/FalsePattern/FalseTweaks/assets/106000018/54e29342-ad4c-4d8d-8f03-8498984edf80

[FalsePattern]

The layered snow flickers seems like a different flicker bug, as it's not the entire chunk flickering, just the snow, so I moved that to a different issue.

[Darek505]

@FalsePattern , I checked d0550b1, and both my tests seem to be successful, I can’t say for sure that the problem is fixed, since this requires longer testing, but so far everything seems to be fine

Update: It seems that 2 bug is also fixed (certain chunks were not rendered until they were updated). Also, when testing for 10 minutes, no problems with rendering were identified