FalsePattern / FalseTweaks

Multithreaded rendering plus a large collection of improvements, fixes, optimizations and additions to 1.7.10 clients.
https://falsepattern.com/mc
Other
57 stars 6 forks source link

Incompatibility when used together with lwjgl3ify with other mods #99

Open Darek505 opened 1 year ago

Darek505 commented 1 year ago

This mod (at least since the latest versions) can run with lwjgl3ify alone, but when certain mods are added, it crashes.

Here is a list of mods with their stacktraces that crash when using lwjgl3ify and falsetweaks: https://pastebin.com/vxJtwZAg

(This is definitely related to falsetweaks, because if I remove it, then lwjgl3ify can start with these mods, and when I add falsetweaks , I get these crashes)

oneechanhax commented 11 months ago

Unsure if this is related, GT;NH 2.4.0 with lwjgl3ify for Java 20, is crashing with mixin re-entry errors. No java expert and i dont code java ever. It appears like they are conflicting on a mixin however trying to disable features in falsetweaks and FastCraft doesnt appear to change anything about the crash. Using Falselib for the multithreading-and-tweaks mod and everything loads fine. My GTNH is a little more modded than others with some QOL and perf mods but nothing conflicts except this. Loads when mod is disabled.

Feel free to ask questions or ask for different senarios, not a java dev but I can C++ pretty well and use linux so i am versed in dev work.

Crash https://pastebin.com/jkUUFtzm

Modlist https://pastebin.com/eHbf9sTy

Crimento commented 10 months ago

Just tried this on clean install of just FalseTweaks and LWJGL3ify along with required libs, same result

https://mclo.gs/uQR5v6L

FalsePattern commented 9 months ago

Fixed in 2.7.0 Preview 4 + FalsePatternLib 1.0.0 Preview 3

Darek505 commented 9 months ago

well, on the one hand this is fixed, in that it doesn’t crash on startup, but on the other hand, the world is not rendered at all + items have no textures (looks like a bug like with intel or something similar):

https://github.com/FalsePattern/FalseTweaks/assets/122032896/29da4cae-bc97-48f8-9414-f1e6582aa86d

Mods: +unimixins-all-1.7.10-0.1.14 falsepatternlib-mc1.7.10-1.0.0-pre03 falsetweaks-mc1.7.10-2.7.0-pre04 lwjgl3ify-1.5.4

in fact, this this has nothing to do with this problem, because this report talks specifically about the crash, and it has been fixed, but if we talk about the general compatibility between falsetweaks and lwjgl3ify , then the bug still exists

FalsePattern commented 9 months ago

2.7.0 should work now, make sure to delete falsetweaks.cfg and let it regenerate with default settings if it's still broken

I have tested it on:

Darek505 commented 9 months ago

I tried deleting falsetweaks.cfg, it didn't help. tested it on:

falsepatternlib - 1.0.0 Preview 3 falsetweaks - 2.7.0 unimixins - all-0.1.14

installed via PrismLauncher (lwjgl3ify-1.5.4-multimc.zip)

no error if there is no falsetweaks

FalsePattern commented 9 months ago

Hmmm... try setting TEXTURE_OPTIMIZATIONS to false in the falsetweaks config and see if that does anything, it might be a conflict with how i handle textures vs how lwjgl3ify handles them.

Crimento commented 9 months ago

@FalsePattern can confirm, disabling texture optimization helped. With it same thing happening with LWJGL3 (Win 11, RTX2070S@536.99, Liberica JDK 20)

image