FalsehoodMC / Fabrication

A huge collection of vanilla tweaks and small features for both Fabric and Forge.
https://www.curseforge.com/minecraft/mc-mods/fabrication
MIT License
113 stars 23 forks source link

Expanding instant pickup to all player kills #678

Closed anoomolu closed 1 week ago

anoomolu commented 10 months ago

This is a super useful feature, and I think the only way it could be improved upon is allowing all mob drops caused by player kills to also be vacuumed up. This would be nice QoL for bows and crossbows, tridents too.

Haven't thought about the balance implications, perhaps ranged options could be limited to loyalty tridents? 🤷🏽

edit: It already works as intended if within melee range of the mob. edit 2: it works on some ranged attacks like botania's terra blade beam or key of the kings law, idk why that's the case

anoomolu commented 1 week ago

Thought about it a bit more and I think the feature works fine as is - ranged weapons already have the advantage of not needing to get close, doesn't really need a loot delivery system as well.