search

FalsehoodMC / Fabrication

A huge collection of vanilla tweaks and small features for both Fabric and Forge.
https://www.curseforge.com/minecraft/mc-mods/fabrication
MIT License
113 stars 23 forks source link

"Invincible" item_despawn.ini tag bug in 3.4.11 is worse than before #709

Closed Abalieno closed 7 months ago

Abalieno commented 7 months ago

As written here (and documented extensively on discord, since this took me several hours to troubleshoot to this point): https://github.com/FalsehoodMC/Fabrication/commit/6d468f81aff74e3aa53857dae49fd8bc5b3e10db

Obviously -32 - -64 = +32

I tagged amethyst shards to use the "forever" feature and noticed they didn't drop. Long story short, they did drop, but as long a cluster was below y = 32, then the drop would only appear at y = 1

That's what the code does.

If that piece of code is meant to port back to y = 1 those items that fall 32 blocks UNDER bedrock, then at the very least it should be -32 + world.getBottomY()

Because being world bottom negative, the subtraction makes the result positive, rather than being added to negative.

SFort commented 7 months ago

sorry

Abalieno commented 7 months ago

Could you publish on CF? I need to be able to distribute the fix (and test it, even if it seems fine).

SFort commented 7 months ago

I just realized that the really item should teleport to -63 and not to 1 so expect another release