search

Faltenreich / SkeletonLayout

Skeleton view pattern for Android
Apache License 2.0
505 stars 65 forks source link

View types #6

Open KennyGoers opened 5 years ago

KennyGoers commented 5 years ago

Is there a way to hook into the skeleton view factory? It would be nice to add or exclude view types (for example I have a MPAndroidChat)

Faltenreich commented 5 years ago

Good idea! I guess that currently the whole chart is masked and you would like to mask only certain sub-elements of the chart, am I right?

KennyGoers commented 5 years ago

Actually at the time of showSkeleton() its a ViewGroup with no children so it doesn't show. It comes out better as an entire block. For the time being I just put the Chart in a Framelayout with a View.

Faltenreich commented 5 years ago

I understand. You idea of an option to in- or exclude certain Views and ViewGroups makes much sense and I will think of an implementation in the near future. Of course you are free to submit a pull request which I would gladly review if you are in a hurry.

vvictor10 commented 3 years ago

@Faltenreich Nice work on the library. Any updates on this issue. I have a loading state screen, where I need to exclude certain views from being masked and show the actual content on them. Would be great to specify a boolean to exclude them from the masking process. Thanks