generate-files github workflow files pull requests that are blocked because validate-yaml never runs

FamilySearch / GEDCOM

Apache License 2.0

153 stars 20 forks source link

generate-files github workflow files pull requests that are blocked because validate-yaml never runs #503

Open dthaler opened 2 weeks ago

dthaler commented 2 weeks ago

See https://github.com/orgs/community/discussions/57484 for explanation.

https://github.com/FamilySearch/GEDCOM/blob/main/.github/workflows/generate-files.yml#L72 current uses the GITHUB_TOKEN which is the problem.

The recommended fix seems to be to use a PAT rather than GITHUB_TOKEN.

tychonievich commented 2 weeks ago

As noted in the linked discussion, this can be worked around by closing and then re-opening the blocked PR. I've verified that that workaround unblocks the blocked PRs we had on our various repos.

I'm not very keen on making a PAT and attaching it to the actions through a GitHub app; I don't have a deep understanding of that process so I might be wrong, but what I do looks to me like it overly ties the workflow to a single user.