ghost
commented
9 years ago Was this the result of calling a specific method in this library? If so, what parameters were specified (if applicable)?
Closed RobertCMartin closed 9 years ago
ghost
commented
9 years ago Was this the result of calling a specific method in this library? If so, what parameters were specified (if applicable)?
RobertCMartin
commented
9 years ago Shane:
I'm using Visual Basic and calling Person Read in the sandbox. I get the same result (period preceding middle initial) whether I use my code or the compiled C# FamilySearch.API. Beats me what parameters the compiled FamilySearch.API uses. My code and the output are reproduced below.
Bob
Private Function ReadUsingMyCode(personID As String) As String
Dim Request As HttpWebRequest
Dim Response As HttpWebResponse = Nothing
Dim Reader As StreamReader
Dim Address As Uri
Dim ObjectX As Object
Dim ReturnValue As String = String.Empty
Address = NewUri("https://sandbox.familysearch.org/platform/tree/persons/" & _
personID)
Request = DirectCast(WebRequest.Create(Address), HttpWebRequest)
Request.Method = "GET"
Request.Accept = "application/x-gedcomx-v1+json"
Request.Headers.Add("Authorization", "Bearer " & g.CurrentAccessToken)
Try
Response = DirectCast(Request.GetResponse(), HttpWebResponse)
Reader = New StreamReader(Response.GetResponseStream())
ObjectX = JsonConvert.DeserializeObject(Reader.ReadToEnd)
ReturnValue = ObjectX.ToString
Catch ex As System.Net.WebException
MsgBox(ex.Message)
Finally
If Not Response Is Nothing Then Response.Close()
End Try
Return ReturnValue
End FunctionHere is what I get. I have highlighted the error:
{
"persons": [
{
"id": "KWQ7-Y58",
"links": {
"spouses": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/spouses"
},
"ancestry": {
"href":"https://sandbox.familysearch.org/platform/tree/ancestry?person=KWQ7-Y58"
},
"person": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58"
},
"parents": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/parents"
},
"person-with-relationships": {
"href":"https://sandbox.familysearch.org/platform/tree/persons-with-relationships?p erson=KWQ7-Y58"
},
"descendancy": {
"href":"https://sandbox.familysearch.org/platform/tree/descendancy?person=KWQ7-Y58"
},
"discussion-references": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/discussion- references"
},
"merge": {
"template":"https://sandbox.familysearch.org/platform/tree/persons/{pid}/merges/{dpid}{ ?filter,access_token}",
"type":"application/json,application/x-fs-v1+json,application/x-fs-v1+xml,applicati on/xml,text/html",
"accept": "application/x-fs-v1+json,application/x-fs-v1+xml",
"allow": "OPTIONS,GET,POST",
"title": "Person Merge"
},
"change-history": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/changes"
},
"children": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/children"
},
"evidence-references": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/memory-refe rences"
},
"spouse-relationships": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/spouse-rela tionships"
},
"child-relationships": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/child-relat ionships"
},
"collection": {
"href":"https://sandbox.familysearch.org/platform/collections/tree"
},
"portrait": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/portrait"
},
"parent-relationships": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/parent-rela tionships"
},
"artifacts": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/memories"
},
"source-references": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/source-refe rences"
},
"matches": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/matches"
},
"non-matches": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/not-a-match "
},
"portraits": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/portraits"
},
"notes": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/notes"
},
"source-descriptions": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/sources"
}
},
"identifiers": {
"http://gedcomx.org/Persistent": [
"https://sandbox.familysearch.org/ark:/61903/4:1:KWQ7-Y58"
]
},
"living": false,
"gender": {
"id": "V.777-777H",
"links": {
"conclusion": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/conclusions /V.777-777H"
}
},
"attribution": {
"contributor": {
"resource":"https://sandbox.familysearch.org/platform/users/agents/MMDZ-DPJ",
"resourceId": "MMDZ-DPJ"
},
"modified": 1381208540796
},
"type": "http://gedcomx.org/Female"
},
"names": [
{
"id": "V.777-777L",
"links": {
"conclusion": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/conclusions /V.777-777L"
}
},
"attribution": {
"contributor": {
"resource":"https://sandbox.familysearch.org/platform/users/agents/MMDZ-DPJ",
"resourceId": "MMDZ-DPJ"
},
"modified": 1381208540796
},
"type": "http://gedcomx.org/BirthName",
"nameForms": [
{
"fullText": "Ava .F GEORGE",
"parts": [
{
"type": "http://gedcomx.org/Given",
"value": "Ava .F"
},
{
"type": "http://gedcomx.org/Surname",
"value": "GEORGE"
}
]
}
],
"preferred": true
}
],
"facts": [
{
"id": "V.777-7771",
"links": {
"conclusion": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/conclusions /V.777-7771"
}
},
"attribution": {
"contributor": {
"resource":"https://sandbox.familysearch.org/platform/users/agents/MMDZ-DPJ",
"resourceId": "MMDZ-DPJ"
},
"modified": 1381208540796
},
"type": "http://gedcomx.org/Birth",
"date": {
"original": "9 September 1809",
"normalized": [
{
"lang": "*",
"value": "9 September 1809"
},
{
"value": "9 September 1809"
}
]
},
"place": {
"original": "Layton, Weber, Utah"
}
},
{
"id": "V.777-7774",
"links": {
"conclusion": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/conclusions /V.777-7774"
}
},
"attribution": {
"contributor": {
"resource":"https://sandbox.familysearch.org/platform/users/agents/MMDZ-DPJ",
"resourceId": "MMDZ-DPJ"
},
"modified": 1381208540796
},
"type": "http://gedcomx.org/Burial",
"date": {
"original": "12 September 1884",
"normalized": [
{
"lang": "*",
"value": "12 September 1884"
},
{
"value": "12 September 1884"
}
]
},
"place": {
"original": "Layton, Weber, Utah"
}
},
{
"id": "V.777-777N",
"links": {
"conclusion": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/conclusions /V.777-777N"
}
},
"attribution": {
"contributor": {
"resource":"https://sandbox.familysearch.org/platform/users/agents/MMDZ-DPJ",
"resourceId": "MMDZ-DPJ"
},
"modified": 1381208540796
},
"type": "http://gedcomx.org/Christening",
"date": {
"original": "17 September 1809",
"normalized": [
{
"lang": "*",
"value": "17 September 1809"
},
{
"value": "17 September 1809"
}
]
},
"place": {
"original": "Layton, Weber, Utah"
}
},
{
"id": "V.777-777P",
"links": {
"conclusion": {
"href":"https://sandbox.familysearch.org/platform/tree/persons/KWQ7-Y58/conclusions /V.777-777P"
}
},
"attribution": {
"contributor": {
"resource":"https://sandbox.familysearch.org/platform/users/agents/MMDZ-DPJ",
"resourceId": "MMDZ-DPJ"
},
"modified": 1381208540796
},
"type": "http://gedcomx.org/Death",
"date": {
"original": "9 September 1884",
"normalized": [
{
"lang": "*",
"value": "9 September 1884"
},
{
"value": "9 September 1884"
}
]
},
"place": {
"original": "Layton, Weber, Utah"
}
}
],
"display": {
"name": "Ava .F GEORGE",
"gender": "Female",
"lifespan": "1809-1884",
"birthDate": "9 September 1809",
"birthPlace": "Layton, Weber, Utah",
"deathDate": "9 September 1884",
"deathPlace": "Layton, Weber, Utah"
}
}],
"sourceDescriptions": [
{
"id": "SD-KWQ7-Y58",
"citations": [
{
"lang": "en",
"value": "\"Family Tree,\" database, <i>FamilySearch</i>(http://familysearch.org : modified 24 October 2014, 23:34), entry for Ava .F GEORGE(PID https://sandbox.familysearch.org/ark:/61903/4:1:KWQ7-Y58); contributed by various users."
}
],
"about": "#KWQ7-Y58",
"componentOf": {
"description":"https://sandbox.familysearch.org/platform/collections/tree"
},
"titles": [
{
"value": "Ava .F GEORGE"
}
],
"resourceType": "http://gedcomx.org/Person",
"identifiers": {
"http://gedcomx.org/Persistent": [
"https://sandbox.familysearch.org/ark:/61903/4:1:KWQ7-Y58"
]
},
"modified": 1414193645000
}],
"description": "#SD-KWQ7-Y58"
}
Robert C. Martin Law Office 304 West Park Street Franklin PA 16323
(814) 437-2033 Fax (814) 437-2683
mailto:rcmlaw@verizon.net rcmlaw@verizon.net
www.robertcmartinlawoffice.com
This is an attorney communication and may be confidential and privileged. Please do not print, copy, forward, use, or disclose this e-mail or its attachments without the consent of Robert C. Martin Law Office or the intended addressee. If you received this e-mail in error, please let us know immediately by calling (814) 437-2033 or e-mailing mailto:rcmlaw@verizon.net rcmlaw@verizon.net.
REQUIRED IRS CIRCULAR 230 DISCLAIMER: No tax advice in this e-mail or its attachments may be used (1) to avoid a penalty imposed by federal tax law, or (2) to promote, market, or recommend any transaction or matter. Only a formal, written tax opinion meeting IRS requirements may be used for those purposes.
From: shanewalters [mailto:notifications@github.com] Sent: Wednesday, November 12, 2014 10:26 PM To: FamilySearch/gedcomx-csharp Cc: RobertCMartin Subject: Re: [gedcomx-csharp] Abbreviated middle names preceded by period (#16)
Was this the result of calling a specific method in this library? If so, what parameters were specified (if applicable)?
Reply to this email directly or view it on GitHub https://github.com/FamilySearch/gedcomx-csharp/issues/16#issuecomment-62835 964 . https://github.com/notifications/beacon/AJM5PpuMpYYweysCwpQeRgzW_gda9FAOks5 nNBxUgaJpZM4C447h.gif
RobertCMartin
commented
9 years ago One more thought-I have gotten this same result with multiple person IDs, but the IDs are all near KWQ7-Y58-such as KWQ7-Y59. It's possible that these were all input by somebody who habitually makes the same kind of typo, hitting the period before the middle initial.
Robert C. Martin Law Office 304 West Park Street Franklin PA 16323
(814) 437-2033 Fax (814) 437-2683
mailto:rcmlaw@verizon.net rcmlaw@verizon.net
www.robertcmartinlawoffice.com
This is an attorney communication and may be confidential and privileged. Please do not print, copy, forward, use, or disclose this e-mail or its attachments without the consent of Robert C. Martin Law Office or the intended addressee. If you received this e-mail in error, please let us know immediately by calling (814) 437-2033 or e-mailing mailto:rcmlaw@verizon.net rcmlaw@verizon.net.
REQUIRED IRS CIRCULAR 230 DISCLAIMER: No tax advice in this e-mail or its attachments may be used (1) to avoid a penalty imposed by federal tax law, or (2) to promote, market, or recommend any transaction or matter. Only a formal, written tax opinion meeting IRS requirements may be used for those purposes.
From: shanewalters [mailto:notifications@github.com] Sent: Wednesday, November 12, 2014 10:26 PM To: FamilySearch/gedcomx-csharp Cc: RobertCMartin Subject: Re: [gedcomx-csharp] Abbreviated middle names preceded by period (#16)
Was this the result of calling a specific method in this library? If so, what parameters were specified (if applicable)?
Reply to this email directly or view it on GitHub https://github.com/FamilySearch/gedcomx-csharp/issues/16#issuecomment-62835 964 .Image removed by sender.
stoicflame
commented
9 years ago I can confirm that this isn't a bug in the SDK. That's just the way the data looks. You'll see the same thing in a browser, for example:
RobertCMartin
commented
9 years ago Thanks. I agree. It's a problem with the way the data was input. Thanks.
Both Person.GetDisplayProperties.Name and Name.NameForm.FullText return names with abbreviated middle name PRECEDED by period, thus: Ava .F GEORGE [KWQ7-Y58] Riley .F WILEY [KWQ7-Y59] Dempsey .M LUCAS [KWQ7-Y56]