search

FamilySearch / gedcomx-csharp

C# Libraries for GEDCOM X Processing
Apache License 2.0
42 stars 21 forks source link

Added redirectable rest request support. #31

Closed ghost closed 9 years ago

ghost commented 9 years ago

This should be a backwards compatible update allowing IRestRequest objects to redirect the client when the resource is on a different domain. Pay particular attention to RestClientExtensions.cs and FilterableRestClient.cs.

stoicflame commented 9 years ago

You rock.

So there are a couple of tests that failed. Are those problems on the server-side or the client side?

ghost commented 9 years ago

The three failing tests also failed before I started this (I reforked the repo, ran all tests). I didn't look into the failing too deeply, but I'm certain they're not related to this PR.

TestInitiateAuthorizationInvalidParameter: If I remember correctly, this is because QueryCS is failing to find the correct number of elements from the error selector. This is probably (didn't check) due to rendered HTML changes that the test doesn't know about yet.

TestReadPersonPortraits: This is probably due to a change in the API, but I'm not sure.

TestReadCurrentTreePersonExpecting200Response: Same as above. Probably due to a change in the API.

stoicflame commented 8 years ago

Hey, @shanewalters , will you e-mail me when you have a moment? I'm having a hard time finding the appveyor project that was set up for this project.

ghost commented 8 years ago

Done