search

FamilySearch / gedcomx-csharp

C# Libraries for GEDCOM X Processing
Apache License 2.0
41 stars 21 forks source link

Migrate to integration instead of sandbox urls and update NuGet spec files #40

Closed wooddani closed 7 years ago

weitzhandler commented 7 years ago

Yep. Compelling. Thank you!

misbach commented 7 years ago

@wooddani Is there a reason why we never accepted this request? Was it just an oversight on my part?

weitzhandler commented 7 years ago

This is how I'm currently using the SDK:

var uri = new Uri("https://integration.familysearch.org/platform/collections/tree");
var tree = new FamilySearchFamilyTree(uri);
var state = tree.AuthenticateViaOAuth2Password(Username, Password, ClientId);
wooddani commented 7 years ago

No reason that I know of. I thought this had been accepted and odd that it is a new pull request. If I need to push a new NuGet out I can. I will look at my NuGet push directly and see if it went up.

wooddani commented 7 years ago

It may have just shown up because of https://github.com/weitzhandler 's comment

misbach commented 7 years ago

Weird! It looks like we never merged this. Check out this line, it still shows "sandbox" instead of "integration" which this pull request has. https://github.com/FamilySearch/gedcomx-csharp/blob/master/FamilySearch.Api/EnvironmentEnum.cs#L8

I'll merge it, and you can push out the nuget packages.