FamilySearch / gedcomx-java

Java support for GEDCOM X
Apache License 2.0
53 stars 34 forks source link

gedcomx-model includes other/RS specification fields #87

Open thnaeff opened 2 years ago

thnaeff commented 2 years ago

The gedcomx-java project in general and specifically the gedcomx-model is described as

This is where the Java classes that correspond to the GEDCOM X data types defined by the GEDCOM X Conceptual Model...

I see "RS" only mentioned for the (deprecated) client implementation and for the extensions module.

However, various classes in the gedcomx-model contain other fields - for example from the RS specification. A few examples:

Should the documentation be updated to mention that the gedcomx-model is a combination of conceptual model + RS extension (if that was intended)? Or, should the model be separated into conceptual model and a model that applies the extension?

stoicflame commented 2 years ago

Hi!

Thanks for the report.

Yeah we've been a little looser with the gedcomx-model Java implementation since it's not the canonical definition of the model. So we've allowed some extensions to leak in there, and in general it's worked out fine. We should update the documentation to reflect that. It would also be nice to explicitly indicate any properties that belong in the RS spec.