search

FamilySearch / gedcomx-java

Java support for GEDCOM X
Apache License 2.0
53 stars 34 forks source link

Add Branch to FactType #92

Closed thnaeff closed 1 year ago

thnaeff commented 1 year ago

Add 'Branch' to FactType, as specified here http://www.gedcomx.org/types/FactType.html and here https://github.com/FamilySearch/gedcomx/blob/master/specifications/fact-types-specification.md#21-person-fact-types

image

https://github.com/FamilySearch/gedcomx-java/blob/b6496feff8f405176589493d9f339080d596b8ce/gedcomx-model/src/main/java/org/gedcomx/types/FactType.java#L106

stoicflame commented 1 year ago

Thanks, we'll get it added.

thnaeff commented 1 year ago

Thanks, we'll get it added.

Thanks for your quick reply. I figured why not just open a PR (see PR #93 ) - I appreciate all the work done here. I will be working with this here and there over the next year or so and would be happy to contribute where I can. If you have some formal contribution process documented, please let me know.

stoicflame commented 1 year ago

GH issues and PRs are great! Thanks for contributing!