FamilySearch / gedcomx-viewer

UI for viewing and editing GEDCOM X data.
19 stars 10 forks source link

Show multiple occupations in viewer #4

Closed stoicflame closed 6 years ago

stoicflame commented 6 years ago

From @naisbitt on March 30, 2018 16:15

I have a person multiple occupations, and it would be nice to see that in the view

      "facts": [
        {
          "type": "http://gedcomx.org/Occupation",
          "value": "Pastor",
          "fields": [
            {
              "type": "http://gedcomx.org/Occupation",
              "values": [
                {
                  "type": "http://gedcomx.org/Interpreted",
                  "labelId": "PR_OCCUPATION",
                  "text": "Historian"
                },
                {
                  "type": "http://gedcomx.org/Interpreted",
                  "labelId": "PR_OCCUPATION",
                  "text": "Author"
                },
                {
                  "type": "http://gedcomx.org/Interpreted",
                  "labelId": "PR_OCCUPATION",
                  "text": "Rev"
                },
                {
                  "type": "http://gedcomx.org/Interpreted",
                  "labelId": "PR_OCCUPATION",
                  "text": "Pastor"
                }
              ]
            }
          ]
        }
      ],

Copied from original issue: fs-eng/gedcomx-viewer#4

stoicflame commented 6 years ago

So those should be added as different Occupation facts, no?

stoicflame commented 6 years ago

From @naisbitt on March 30, 2018 16:23

The way it's shown above is how the robokeyer did it (I updated it to include the full facts array). It was one fact with all of those interpreted fields. Is that weird?

stoicflame commented 6 years ago

From @naisbitt on March 30, 2018 16:39

If we change Dexter to add them as different facts, I believe the viewer works the way it is. So, maybe this issue is unnecessary (assuming we make dexter create separate facts)