search

FamilySearch / gedcomx

An open data model and an open serialization format for exchanging genealogical data.
http://www.gedcomx.org
Apache License 2.0
355 stars 67 forks source link

Too many proofStatements? #190

Closed nilsbrummond closed 12 years ago

nilsbrummond commented 12 years ago

Hello,

I was looking at the logical model based on the https://github.com/nilsbrummond/gedcomx/blob/master/specifications/conceptual-model-specification.md#the-gedcom-x-conceptual-model spec, and considering how one person with one name would be modeled.

I have this zargo file I created while going over the spec: https://github.com/nilsbrummond/gedcomx/blob/master/specifications/support/logical-model-gedcomx.zargo

Class Diagram here: https://github.com/nilsbrummond/gedcomx/blob/master/temp/ClassDiagramPersonwithaName.png Each color represents a path to a distinct proofStatement instance if I read the spec right.

It seems there is a minimum of 4 "Attribution.proofStatement"s needed in modeling one person with one name. Is this correct?

To support the GPS, shouldn't there be one proofStatement per GPS activity regardless of how many GenealogicalResource objects are defined by the GPS activity?

Person:

  1. Person is-a GenealogicalResource has-a Attribution has-a proofStatements.
  2. Person has-a list of SourceReference objects, each SourceReference has-a Attribution has-a proofStatements.

Name:

  1. Name is-a Conclusion is-a GenealogicalResource has-a Attribution has-a proofStatements.
  2. Name is-a Conclusion has-a list of SourceReference objects, each SourceReference has-a Attribution has-a proofStatements.

Does the Attribution of a SourceReference have a different meaning then the attribution of a GenealogicalResource ?

thomast73 commented 12 years ago

Thank you for taking a look at this.

It turns out that attribution proofStatement property was not named particularly well. It is really something more like a "commit message" in a version control system. We are in the process of refactoring the classes used to describe sources, proof statements, etc. Our current proposal has us renaming the proofStatement to justification.

All of the refactoring (though still a work in progress) can be viewed and commented on via pull request #182.

nilsbrummond commented 12 years ago

Okay. Gonna close this then.