search

FamilySearch / gedcomx

An open data model and an open serialization format for exchanging genealogical data.
http://www.gedcomx.org
Apache License 2.0
359 stars 67 forks source link

Adding a fact type for civil award #315

Closed vbrossier closed 6 years ago

vbrossier commented 6 years ago

It can be usefull for a person that have a civil medal or decoration.

stoicflame commented 6 years ago

Nice. Seems like a good way to capture and distinguish from a MilitaryAward, yes?

vbrossier commented 6 years ago

Yes exactly. Some medals are not military. And they are not related to studies either (http://gedcomx.org/Education)

pirtleshell commented 6 years ago

Has there ever been discussion around a more general Award fact type with a type or category field that could be used to distinguish from Military, Civil, or some other kind?

It seems like an unnecessary complication to have different fact types for different sorts of awards that will inevitably have similar fields. Beyond increased flexibility, an Award fact type would also prevent the need to add a fact type for every newly conceived award type in the future.

I understand something like that (removing MilitaryAward) would not be backwards-compatible with the current fact type list. In that case, I guess I'm just questioning the "Civil" word choice. Is a soccer trophy a "civil" award? A Nobel Prize? What about winning the lottery?

stoicflame commented 6 years ago

Has there ever been discussion around a more general Award fact type with a type or category field that could be used to distinguish from Military, Civil, or some other kind?

There's already a Qualifier on Fact that could be used to "qualify" the award (e.g. as a civil award). But assuming we keep MilitaryAward for backwards compatibility, what other qualifiers would there be other than Civil?

thomast73 commented 6 years ago

So...I was trying to answer this question for myself. I could think of religious/ecclesiastical as another category. I could think of honors bestowed by a sovereign (I was thinking about knighthood...but cannot find an example of what I was remembering). So...then I found this page...and it will get you thinking about how vast "award" is as a category. It mentions a number of categories...and links to a number of other pages...that link to other pages. You get the point. https://en.wikipedia.org/wiki/List_of_awards

stoicflame commented 6 years ago

@vbrossier what do you think about defining this type more generically (e.g. Award) and defining a list of qualifiers for the award type (including Civil)?

vbrossier commented 6 years ago

@stoicflame Yes, it seems to be a good solution !

vbrossier commented 6 years ago

I have made a new commit on my pull request to change that

stoicflame commented 6 years ago

I went ahead and accepted this proposal. It seems like we should define the award qualifiers in the conceptual model section 3.14.2. If someone would like to put together a pull request, I'd be happy to consider it and merge it. I'm a bit booked at the moment, but I should be able to put it together in the next few weeks some time.