search

FamilySearch / gedcomx

An open data model and an open serialization format for exchanging genealogical data.
http://www.gedcomx.org
Apache License 2.0
349 stars 67 forks source link

Event/Fact missing Address #336

Closed diamondq closed 4 months ago

diamondq commented 5 months ago

According to the GEDCOM 5.5.5 specification, Events (and Facts/Attributes) have an address associated with them. Gedcomx does not.

GEDCOM 5.5.5

EVENT_DETAIL:=
   n TYPE <EVENT_OR_FACT_CLASSIFICATION>
   n DATE <DATE_VALUE>
   n <<PLACE_STRUCTURE>>
   n <<ADDRESS_STRUCTURE>>
   n AGNC <RESPONSIBLE_AGENCY>
   n RELI <RELIGIOUS_AFFILIATION>
   n CAUS <CAUSE_OF_EVENT>
   n <<NOTE_STRUCTURE>>
   n <<SOURCE_CITATION>>
   n <<MULTIMEDIA_LINK>>

EVENT_DETAIL is used as the basis of events (via INDIVIDUAL_EVENT_STRUCTURE and FAMILY_EVENT_STRUCTURE) and facts/attributes (via INDIVIDUAL_ATTRIBUTE_STRUCTURE).

EVENT_DETAIL contains a PLACE and an ADDRESS.

Gedcomx

As of reporting, Events ( Defined here ) and Facts ( Defined here ) only have a PLACE reference.

The GEDCOM5 to GEDCOMX conversion library acknowledges that it's missing.

FactMapper.java:240

Suggestion

As there is already an Address Data type, it should be able to be added to the Events and Facts Data Type as an OPTIONAL element without too much impact.

stoicflame commented 4 months ago

Hello @diamondq! Thanks for the enhancement request.

We believe that adding Address as a property to the Event and/or Fact type would be redundant. The PlaceReference has plenty of specificity for mapping an address. At a bare minimum you could just put the address in the original property, but you could also map the address to multiple levels of a PlaceDescription object (including lat/long geo coordinates) and reference the PlaceDescription with the PlaceReference.

So with respect and appreciation we're going to decline this suggestion.