search

Famous / engine

MIT License
1.75k stars 249 forks source link

Fix: showing child components on hide in Node [#97865428] #370

Closed solomon-gumball closed 9 years ago

solomon-gumball commented 9 years ago

fixes -> https://github.com/Famous/engine/issues/345

alexanderGugel commented 9 years ago

This should be done in the Dispatch, not the Node IMO. Just to be consistent (like in Dispatch#mount and Dispatch.dismount).

( https://github.com/Famous/engine/blob/master/core/Dispatch.js#L208 )

solomon-gumball commented 9 years ago

Good point Alex. Changed.

michaelobriena commented 9 years ago

@redwoodfavorite can you provide an example with this fix?

michaelobriena commented 9 years ago

landed as 3ccd502