fix: Properly mount DOMElement

Famous / engine

MIT License

1.75k stars 250 forks source link

fix: Properly mount DOMElement #449

Open alexanderGugel opened 9 years ago

alexanderGugel commented 9 years ago

DOMElements are components, therefore it should be able to instantiate them in an isolated fashion and then add them at a later point in time using Node#addComponent.

Other issues this PR addresses:

Show DOMElement when onShow is being invoked
Keep track of cutout state
Prefix private methods with _

This is the beginning of a general refactor of some parts of the platform.

alexanderGugel commented 9 years ago

Build on Travis CI failed again because of GeometryHelper.spec.js.

Couldn't reproduce on my local machine. This seems to be a pretty weird test case.

while tape ./webgl-geometries/test/*.js; do ; done

michaelobriena commented 9 years ago

Overall I like but have a few issues with the implementation. Will comment inline

alexanderGugel commented 9 years ago

@michaelobriena Did you have a change to add the inline comments?