Open alexanderGugel opened 9 years ago
Build on Travis CI failed again because of GeometryHelper.spec.js
.
Couldn't reproduce on my local machine. This seems to be a pretty weird test case.
while tape ./webgl-geometries/test/*.js; do ; done
Overall I like but have a few issues with the implementation. Will comment inline
@michaelobriena Did you have a change to add the inline comments?
DOMElements are components, therefore it should be able to instantiate them in an isolated fashion and then add them at a later point in time using
Node#addComponent
.Other issues this PR addresses:
onShow
is being invoked_
This is the beginning of a general refactor of some parts of the platform.