Firefox 40.0 is generating "node is null" errors when events from other frameworks bubble into Famous (for example, from D3).
The attached patch to Famous#DOMRenderer._getPath() fixes it. It's a patch against the built famous.js but it should be clear where the required change is and its purpose should make sense just from looking at the code.
Grab me on slack if you need more info.
Index: WarRoom/lib/famous-20150801-622461886b5162f8dc42f91483b04d758b507d72.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- WarRoom/lib/famous-20150801-622461886b5162f8dc42f91483b04d758b507d72.js (revision 2ff2a6e3c886e5aca9b200d93c3d3159dd1f7430)
+++ WarRoom/lib/famous-20150801-622461886b5162f8dc42f91483b04d758b507d72.js (revision )
@@ -8993,7 +8993,7 @@
// TODO move into _triggerEvent, avoid object allocation
var path = [];
var node = ev.target;
- while (node !== document.body) {
+ while (node && node !== document.body) {
path.push(node);
node = node.parentNode;
}
Firefox 40.0 is generating "node is null" errors when events from other frameworks bubble into Famous (for example, from D3).
The attached patch to
Famous#DOMRenderer._getPath()
fixes it. It's a patch against the built famous.js but it should be clear where the required change is and its purpose should make sense just from looking at the code.Grab me on slack if you need more info.