Closed trusktr closed 10 years ago
We should really support just one or the other of string classes vs an array of classes. Supporting both would result in undefined or at least unintuitive behavior. Given that we are discussing an HTML interface, per HTML conventions it feels more natural to me to support a string of classes vs passing in an array of classes. The latter can be transformed to the former with a simple .join(' ')
The setClasses method is still available on the Surface itself if imperative manipulation is ever needed. I will go ahead and close this, but let's discuss more if you feel strongly about it.
In this example:
the
fa-classes
doesn't add classes to the generated element, butclasses
is a valid property that can be defined in the options passed tonew Surface()
. i.e.:Using just a
class
attribute on the<fa-surface>
works, but it'd still be nice to support all of the native famo.us APIs one-to-one.