search

Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.
https://famo.us/angular
Mozilla Public License 2.0
1.92k stars 275 forks source link

fix: minification process #178

Closed hannahhoward closed 10 years ago

hannahhoward commented 10 years ago

Hi,

Currently famous-angular.min.js in your bower package actually throws a javascript error because you don't use the full array syntax in defining your angular modules, so minification actually breaks dependency injection. Rather than force you to use array syntax in your source, I added ngAnnotate to the build process, which automatically converts module definitions to array syntax, so minification doesn't break the code. Thanks!

hannahhoward commented 10 years ago

oh also I sign a contributor agreement but I don't think I got an email that i can forward. I'll take another look.

zackbrown commented 10 years ago

Great, thank you for this! This is a good catch. I received your confirmation for the CLA, so I'll go ahead and merge this in.