search

Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.
https://famo.us/angular
Mozilla Public License 2.0
1.92k stars 275 forks source link

feat: container surface removes children #194

Closed steveblue closed 10 years ago

steveblue commented 10 years ago

This fix seems to clean up the view that contains a SurfaceContainer after stateChange events fire from ui-router.

Please implement tests on this fix, it's working in our web app, but not 100% sure it's a clean implementation. I basically used the same methods found in other layouts, but the ContainerSurface is a different animal and does not have a sequenceFrom method.

steveblue commented 10 years ago

I just tested this in our web app and the container surface is destroying as prescribed.

zackbrown commented 10 years ago

@steveblue just sent you a more detailed email, but this same issue should be resolved simply by removing the throw statement in fa-container-surface.js (which is done here 422576a573d). This is something we should have caught in the renderGate refactor, but we missed it. Thank you for creating this work-around, either way.