Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.
https://famo.us/angular
Mozilla Public License 2.0
1.92k stars 275 forks source link

=BG= impl remove child for fa-header-footer-layout #203

Closed bguiz closed 10 years ago

bguiz commented 10 years ago

NOTE: It seems more right to do isolate.rendernode.something.set(null) instead of isolate.rendernode.something.set({}), however, this breaks, as the set function in RenderNode currently does not handle a null parameter.

zackbrown commented 10 years ago

This works well; thank you for this! I also added a unit test for fa-header-footer-layout child removal in 2f29afff6f6 . If we run into any issues down the road with .setting to {}, we could set to a new RenderNode() instead.