search

Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.
https://famo.us/angular
Mozilla Public License 2.0
1.92k stars 275 forks source link

fix(faInput): compare attr.disabled with a string to disable click on su... #214

Closed jmeiss closed 10 years ago

jmeiss commented 10 years ago

Hi,

I tried to disable a click on a surface using disabled attribute but as I can see at this line: https://github.com/Famous/famous-angular/blob/master/src/scripts/directives/fa-input.js#L222 the comparison between attr.disabled and false doesn't work because it compare a boolean with a string.

zackbrown commented 10 years ago

Thanks for finding and taking the time to fix this, @jmeiss!

jmeiss commented 10 years ago

It's nothing compared to your work building famous-angular ;)

Thanks for the merge.