fix: Make $animate methods return a promise - for Angular 1.3 compatibility

Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.

https://famo.us/angular

Mozilla Public License 2.0

1.92k stars 275 forks source link

fix: Make $animate methods return a promise - for Angular 1.3 compatibility #228

Closed hannahhoward closed 9 years ago

hannahhoward commented 9 years ago

See https://docs.angularjs.org/api/ngAnimate/service/$animate:

"With AngularJS 1.3, each of the animation methods, on the $animate service, return a promise when called"

We encountered this issue when we tried to you an ng-include directive elsewhere (not in the famous-angular part) of the page.

I'm not sure if this is really the best way to fix it, or even if you're aiming to support Angular 1.3 right now -- but since it is just around the corner thought you should be aware of this issue.

zackbrown commented 9 years ago

Hey @hannahhoward, thanks for this! To my knowledge, this was the largest outstanding breaking change keeping us from tracking 1.3.0. After merging this in, it looks like there are only 3 unit tests breaking (all for fa-edge-swapper, which appears to be working nonetheless, but we'll need to fix those tests) and all of the famous-angular-examples seem to be intact. I expect we'll be officially tracking 1.3.0 with the next release, but it seems like you could work with it sooner if you wanna live on the edge. Please keep us advised if you notice any more issues!