search

Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.
https://famo.us/angular
Mozilla Public License 2.0
1.92k stars 275 forks source link

feat: faDeck Directive #241

Open imheresamir opened 10 years ago

imheresamir commented 10 years ago

Added the Famo.us Deck view as a F/A fa-deck directive. This includes the new attribute fa-open which takes a "true" or "false" value and opens or closes the Deck accordingly.

Added F/A Deck specific tests and an example app in the header comment which should make it easy to document.

Big thanks to Zack for the pointers!

Cheers, Samir

zackbrown commented 10 years ago

This looks great, @imheresamir . A very solid PR (thanks especially for the tests!) It looks like you haven't yet signed Famo.us's CLA: could you please do that so I can merge this in? http://famo.us/cla/

Thanks!

imheresamir commented 10 years ago

Signed. I'm glad you like it :smile:

jmeiss commented 9 years ago

Hi guys,

Is there any news about that PR? Is it a dead PR that will never be merged? It seems to fit one of our needs and would love to try it. (we gonna try it anyway ;) )

Thanks

adrien-gueret commented 9 years ago

Hi guys!

This directive looks amazing: I've downloaded the code and tested it on local and it seems to work well. I just have a very strange issue: this error message appears in the browser console:

Error: fa-options is not supported on FA-DECK

This error is thrown from this file: https://github.com/Famous/famous-angular/blob/master/src/scripts/directives/fa-options.js#L41

The reason is that isolate.renderNode is an instance of RenderNode: it should be an instance of Deck.

The strange part is when I try to change the directive name (from faDeck to a dummy name like faAaa)... it works well!

It looks like it works for all names but faDeck... I have no clues why, it's kind of non-sense for me. Any ideas?