search

Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.
https://famo.us/angular
Mozilla Public License 2.0
1.92k stars 275 forks source link

Unclear things between documentation and reality #259

Closed BernhardBehrendt closed 9 years ago

BernhardBehrendt commented 9 years ago

I followed the instructions in your README and I'm a bit confused because some parts of the files which need to be injected into my HTML are already injected and some not.

I was able to solve the issue but this breaks a general workflow in terms of contributing software to deployment servers.

In README: So what's the problem: Run bower install famous-angular Add the following to your index.html

[...]

So problem is that all required angular-famous package files (famous-angular.js and famous-angular.css) were injected automatically. But the required famous-global.js is not injected.

After some analysis I found there's nof. js File at bower_components/famous/famous-global.js main property (It's inside dist folder). After changing manually inside bower.json (to bower_components/famous/dist/famous-global.js) the inclusion is working.

So It's normally only required to add the correct famous.js file because each required angular-famous dependency is resolved by install with the -S parameter.

jordanpapaleo commented 9 years ago

Hello Bernhard -

Thanks for your findings. I just installed famous-angular with bower. All of the dependencies were installed correctly. I checked the README.md file and in the Installation section it does show the famous-global.js file path in the famous/dist directory. So I think your issue has been resolved. Please confirm.

Thanks for your support,

Jordan