search

Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.
https://famo.us/angular
Mozilla Public License 2.0
1.92k stars 275 forks source link

fix(fa-surface): Use the transclude function from post #329

Closed thaiat closed 9 years ago

thaiat commented 9 years ago

As per angular documentation, the usage of the transclude function from compile has been deprecated in angular 1.3 (started 1.2 I believe).

One should only use transclude provided as the 5th argument of pre or post function to make sure the scope is correct.

For more info : https://github.com/angular/angular.js/issues/9413

thaiat commented 9 years ago

As surface is a leaf node, this change should not have any side effect.

I'm not sure if same fix should be done across all directives...

Let me know what you think