search

Famous / famous-angular

Bring structure to your Famo.us apps with the power of AngularJS. Famo.us/Angular integrates seamlessly with existing Angular and Famo.us apps.
https://famo.us/angular
Mozilla Public License 2.0
1.92k stars 275 forks source link

Cordova - 1px white line when rotating to landscape view #352

Closed jaypanares closed 9 years ago

jaypanares commented 9 years ago

Hi, I'm currently working on a Cordova app using famous-angular and I noticed that whenever I rotate my device to landscape view, a 1px white line appears at the very top of my app. Below is my HTML:

`

Header Title

`

I tried running a vanilla implementation of famous (the timbre menu example) and I don't seem to see the issue. Is this a famous-angular specific bug?

Thanks!

jaypanares commented 9 years ago

I seem to have found out the cause. My padding for elements inside the header surface was going beyond the header size and keeping padding within the header surface size prevented the white line from appearing. I had a top and bottom padding of 100% for the h2 and i element and I assumed it would stretch to the surface size and not beyond it. Closing this issue, unless my assumptions about padding: 100% are wrong. If so, please shed a light on how percentage values in CSS works. Thanks!