search

FamousArchives / examples

[DEPRECATED]
214 stars 74 forks source link

Help users not able to clone directly from git@github.com: #28

Closed jedihe closed 10 years ago

jedihe commented 10 years ago

Had lots of headaches while cloning because of submodules using git@github.com:... URLs. Found a simple method to get it solved quickly (without having to check about SSH keys set up for github or general ssh config).

michaelobriena commented 10 years ago

@jedihe Can you please fill out our Contribute License Agreement (CLA) so we can merge in this fix? Thanks! https://famo.us/cla/individual

jedihe commented 10 years ago

@michaelobriena done!

michaelobriena commented 10 years ago

Thanks! I will look into merging this on Monday.

MylesBorins commented 10 years ago

I think we should hold off on this pull request. Can we not solve this problem by adding http to the gitmodules? On Apr 26, 2014 2:04 PM, "John E. Herreño" notifications@github.com wrote:

@michaelobriena https://github.com/michaelobriena done!

— Reply to this email directly or view it on GitHubhttps://github.com/Famous/examples/pull/28#issuecomment-41480831 .

MylesBorins commented 10 years ago

29 solves this problem. Users can now git clone via http, and no longer require having ssh keys setup.

This has been tested on a personal machine without ssh keys as working

@michaelobriena let me know if you would prefer handling issues on this project and I will refrain from closing them myself in the future

MylesBorins commented 10 years ago

31 Also offers another solution to this