FamousArchives / examples

[DEPRECATED]
214 stars 74 forks source link

Transitionable example: surface doesn't show as of 0.0.4 #5

Closed fettermania closed 10 years ago

fettermania commented 10 years ago

Not new since 0.0.3.

@marklu @michaelobriena @ftripier @dmvaldman

dmvaldman commented 10 years ago

I can't seem to reproduce. It's working fine for me.

marklu commented 10 years ago

Two issues:

1.) The arbitrary maxOffset is inappropriate for the default mobile screen. Lower it to 120. Transitioning the x origin might be more appropriate in this case. 2.) The grid can potentially end up in front in a future version of famo.us. I personally think we should just remove the grid. It's extra code and doesn't serve to show anything.

One additional comment:

This example show a horrible highly inefficient way of using Modifier. Can we at least map this to a CachedMap? Or, better, if you just simply hooked up the transition to origin, the Transitionable can be used directly by the Modifier.

michaelobriena commented 10 years ago

I will look into rewriting this. A lot of the examples are pulled from the header comments that used to have examples which means this code is probably very old.

michaelobriena commented 10 years ago

Example was rewritten