FamousArchives / generator-famous

for those who hate doing things once
123 stars 26 forks source link

Project created with missing lib folder #18

Closed tth2k closed 10 years ago

tth2k commented 10 years ago

Hi,

I followed the instructions on the famous site to install famous, and create a project. A template project is created but it's missing the lib folder, and the below errors are what i've noticed. (apologise i've been on the chat room, but couldn't get any help.)

thanks, tung

[22:24] npm http 304 https://registry.npmjs.org/bower bower famous#flat0.1.1 ENORESTARGET Tag/branch flat0.1.1 does not exist [22:24] Additional error details: No tags found in https://github.com/Famous/famous.git No branches found in https://github.com/Famous/famous.git

MylesBorins commented 10 years ago

That is very odd. Can you try running bower install again? Seems like something might have been going wrong over at github.

digitarald commented 10 years ago

Same problem, one hour of repeated installs and digging. The yeoman task depends on bower being installed globally (haven't looked for the actual culprit in your code). Installing bower and calling bower install fixes this short term, but this bug will hit anybody that doesn't have bower installed globally.

If you run into this problem:

npm install bower -g && bower install
MylesBorins commented 10 years ago

Harald,

If you have the latest version of yo installed it will install bower globally for you. The rare edge case where this will not happen is if you installed yo quite a while ago On Apr 17, 2014 8:53 PM, "Harald Kirschner" notifications@github.com wrote:

Same problem, one hour of repeated installs and digging. The yeoman task depends on bower being installed globally (haven't looked for the actual culprit in your code). Installing bower and calling bower install fixes this short term, but this bug will hit anybody that doesn't have bowerinstalled globally.

If you run into this problem:

npm install bower -g && bower install

— Reply to this email directly or view it on GitHubhttps://github.com/Famous/generator-famous/issues/18#issuecomment-40784987 .

digitarald commented 10 years ago

I executed npm install -g yo generator-famous right before starting the whole process.

MylesBorins commented 10 years ago

Interesting. Are you on Windows, Mac, or Linux?

Does grunt work out of the box? (this is also supposed to be installed by yo by default). On Apr 17, 2014 9:05 PM, "Harald Kirschner" notifications@github.com wrote:

I executed npm install -g yo generator-famous right before starting the whole process.

— Reply to this email directly or view it on GitHubhttps://github.com/Famous/generator-famous/issues/18#issuecomment-40785351 .

digitarald commented 10 years ago

Mac, I also needed to install grunt-cli seperately as I ran into "grunt: command not found" 1

MylesBorins commented 10 years ago

OK. Looks like to is not automatically install grunt cli or bower for you, which it is supposed to do. I'm going to run a couple tests, but if this is the case it might make sense to make that installation step more explicit.

Thanks for taking the time to file the bug and point out my wrong assumptions! On Apr 17, 2014 9:08 PM, "Harald Kirschner" notifications@github.com wrote:

Mac, I also needed to install grunt-cli seperately as I ran into "grunt: command not found" 1http://stackoverflow.com/questions/10667381/node-package-grunt-installed-but-not-available

— Reply to this email directly or view it on GitHubhttps://github.com/Famous/generator-famous/issues/18#issuecomment-40785426 .

digitarald commented 10 years ago

Reading on yeoman website your assumptions are correct:

If you are using npm 1.2.10 or above, this will also automatically install grunt and bower for you. If you're on an older version of npm, you will need to install them manually

I am on npm 1.4.3 and surprisingly this did not apply to me.

MylesBorins commented 10 years ago

Perhaps you should file a bug with yeoman. Maybe it is due to installing more than one package at once? On Apr 17, 2014 9:14 PM, "Harald Kirschner" notifications@github.com wrote:

Reading on yeoman website your assumptions are correct:

If you are using npm 1.2.10 or above, this will also automatically install grunt and bower for you. If you're on an older version of npm, you will need to install them manually

I am on npm 1.4.3 and surprisingly this did not apply to me.

— Reply to this email directly or view it on GitHubhttps://github.com/Famous/generator-famous/issues/18#issuecomment-40785599 .

digitarald commented 10 years ago

It seems that more users ran into this problem as this issue existed before I ran into this. Your grunt task should nicely catch this unhappy path (does lib exists?) when starting up the server.

I neither am a big user (or fan) of bower or yeoman so I don't want to spend too much time investigating. I had most success quickly getting to try stuff out by just using webpack or requirejs directly.

MylesBorins commented 10 years ago

No problem at all! Thanks for the effort so far. I think a simple and conservative solution is to just tell people to install the other two tools in the one liner. On Apr 17, 2014 9:20 PM, "Harald Kirschner" notifications@github.com wrote:

It seems that more users ran into this problem as this issue existed before I ran into this. Your grunt task should nicely catch this unhappy path (does lib exists?) when starting up the server.

I neither am a big user (or fan) of bower or yeoman so I don't want to spend too much time investigating. I had most success quickly getting to try stuff out by just using webpack or requirejs directly.

— Reply to this email directly or view it on GitHubhttps://github.com/Famous/generator-famous/issues/18?utm_campaign=website&utm_source=sendgrid.com&utm_medium=email#issuecomment-40785780 .

tth2k commented 10 years ago

I am on osx lion, and i have a feeling my problems are related to git. Having tried the famous install instructions several times, i'm still experiencing the same issues. Though, I did a routine check on the tools, and found that git --version always results in illegal instruction 4.

Any ideas how I can resolve this?

MylesBorins commented 10 years ago

We have updating the installation instruction to explicity install grunt-cli and bower, which should solve this problem for people

MylesBorins commented 10 years ago

@tth2k Can you open a new issue for your git problem. Please add the output of which git to the report

neofreko commented 10 years ago

Another way to look at this issue: make sure you have bower >= 0.9. I had bower installed globally, but it doesn't recognize bower.json due to it's still at 0.8.4.

Below text copied from bower website

NOTE: In versions of Bower before 0.9.0 the package metadata file was called component.json rather than bower.json. This has changed to avoid a name clash with another tool. You can still use component.json for now but it is deprecated and the automatic fallback is likely to be removed in an upcoming release.