search

FamousArchives / generator-famous

for those who hate doing things once
123 stars 26 forks source link

Version of famous not apparent in build #25

Closed AdamCmiel closed 10 years ago

AdamCmiel commented 10 years ago

I am not sure which api to use with my and other's projects, cannot find the version of famous that the project was built in, as the tool uses a flattened version of the famous src code. Perhaps include a version number in the README or somewhere else in the project.

MylesBorins commented 10 years ago

Hey Adam,

The version is listed in the bower.json https://github.com/Famous/generator-famous/blob/master/app/templates/_bower.json#L30

Do you think it should also be explicitly stated in the readme?

OHHHHH in the build? Like the dist folder?

AdamCmiel commented 10 years ago

I see it in the bower.json now which is probably a great idea. Maybe somewhere closer to the lib/famous but not sure where. Can you update the build of famous by changing the version number and running bower install?

MylesBorins commented 10 years ago

Indeed. The general standard with bower is that version number lives in the bower.json and that is how you track versions in your application. You can change the version in bower json and rerun ‘bower insatll’ and it will modify the version living in app/lib. this is part of the reason why app/lib is actually in the .gitignore and not checked in to repo's.

On May 1, 2014, at 2:49 AM, Adam Cmiel notifications@github.com wrote:

I see it in the bower.json now which is probably a great idea. Maybe somewhere closer to the lib/famous but not sure where. Can you update the build of famous by changing the version number and running bower install?

— Reply to this email directly or view it on GitHub.

MylesBorins commented 10 years ago

closing this one for now... let me know if you have other questions