search

FamousArchives / generator-famous

for those who hate doing things once
123 stars 26 forks source link

default git ignore should not ignore lib/famous #30

Closed DrClick closed 10 years ago

DrClick commented 10 years ago

For contractors like myself and for individual project, we must have the famous lib under source control! This is super easy to overlook!

MylesBorins commented 10 years ago

Why do you need famous lib under source control if you are tracking the version via bower?

On Jun 3, 2014, at 4:41 AM, DrClick notifications@github.com wrote:

For contractors like myself and for individual project, we must have the famous lib under source control! This is super easy to overlook!

— Reply to this email directly or view it on GitHub.

DrClick commented 10 years ago

Well, we were on 0.1.1 of famous for our initial release. We are upgrading to 0.1.2 but if we ever have to go back and hot fix, or switch projects on a different famous version, we need the right bits. Its entirely possible I am missing how to do this, but ideally, when I checkout out my tagged branch for that release, it comes down and runs so I can hot fix whatever I need to.

So can you tell me what I should be doing so that I switch projects / versions and they are on different famous versions (different projects have lifetimes and will be on different famous versions)

-Thomas On Jun 3, 2014, at 7:42 AM, Myles Borins notifications@github.com wrote:

Why do you need famous lib under source control if you are tracking the version via bower?

On Jun 3, 2014, at 4:41 AM, DrClick notifications@github.com wrote:

For contractors like myself and for individual project, we must have the famous lib under source control! This is super easy to overlook!

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

MylesBorins commented 10 years ago

the bower install command will install the version of famous that is referenced in bower.json

Projects created by the generator are expected to have the command npm install && bower install run after cloning to install all dependencies. This gives you the benefit of not polluting your repo with TONS of unneccessary files, and it makes sure you are getting your dependencies from the source.

If you use semver in the bower json such as famous : "~0.2.1" will tell bower to install famous from github using the tag 0.2.1 ... which is the equivalent of https://github.com/Famous/famous/tree/6fc40735d19b291a93be210fd6a755caa6fd1529

If you have some sort of patched version of famous you can point bower towards a specific fork and commit and when you run bower install it will get that very specific version. If you are modifying the frame work this is a much better way to do it, as you will have a separate repo to track the changes you make.

I am going to close this issue for now, but lets keep the conversation going in here if you have more questions, I'm sure others will find the documentation handy as well