Closed DrClick closed 10 years ago
MylesBorins
commented
10 years ago Are they not being found when running
grunt serve:dist ?
On Jun 23, 2014, at 1:26 PM, DrClick notifications@github.com wrote:
I found any css files I included with @import are not being compiled in the dist folder. Is this by design? You mentioned something earlier about fonts should be in the sytles/fonts directory. Is there a document I am missing?
— Reply to this email directly or view it on GitHub.
DrClick
commented
10 years ago They are not found that way either
DrClick
commented
10 years ago I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
MylesBorins
commented
10 years ago can you share the project with me? I’ll noodle and see what edge case the grunt scripts are missing.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
They are not found that way either
— Reply to this email directly or view it on GitHub.
MylesBorins
commented
10 years ago Ahhh… I think I know what is going on… give me a couple minutes and a might have a fix / new version of the generator out.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
— Reply to this email directly or view it on GitHub.
DrClick
commented
10 years ago IBAPP-52 is the branch we are working on. https://github.com/InkaBinka/famous_app3
DrClick
commented
10 years ago Something else that causes us grief is that the cordova files are not put in the dist folder. We have them in the root and access them from the index.js page. Should we be doing something different?
-Thomas
On Jun 23, 2014, at 4:38 PM, Myles Borins notifications@github.com wrote:
Ahhh… I think I know what is going on… give me a couple minutes and a might have a fix / new version of the generator out.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
MylesBorins
commented
10 years ago Anything that needs to be copied can be added to grunt/copy
I’m trying to figure out how to best handle the import edge case… this is a strange one, as the cache busting could much things up.
On Jun 23, 2014, at 1:40 PM, DrClick notifications@github.com wrote:
Something else that causes us grief is that the cordova files are not put in the dist folder. We have them in the root and access them from the index.js page. Should we be doing something different?
-Thomas
On Jun 23, 2014, at 4:38 PM, Myles Borins notifications@github.com wrote:
Ahhh… I think I know what is going on… give me a couple minutes and a might have a fix / new version of the generator out.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
DrClick
commented
10 years ago Is there a recommend LESS/SASS solution? Large apps are still going to require a lot of CSS, wondering what is the famous way.
-Thomas
On Jun 23, 2014, at 4:41 PM, Myles Borins notifications@github.com wrote:
Anything that needs to be copied can be added to grunt/copy
I’m trying to figure out how to best handle the import edge case… this is a strange one, as the cache busting could much things up.
On Jun 23, 2014, at 1:40 PM, DrClick notifications@github.com wrote:
Something else that causes us grief is that the cordova files are not put in the dist folder. We have them in the root and access them from the index.js page. Should we be doing something different?
-Thomas
On Jun 23, 2014, at 4:38 PM, Myles Borins notifications@github.com wrote:
Ahhh… I think I know what is going on… give me a couple minutes and a might have a fix / new version of the generator out.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
MylesBorins
commented
10 years ago I think it is best to think of what the generator outputs as a great starting place… but it still requires some extensions for various use cases.
If you want to be using sass / less you can just add a sass / less grunt plugin.
Let me keep digging through and I’ll let you know if I have anything solid
On Jun 23, 2014, at 1:43 PM, DrClick notifications@github.com wrote:
Is there a recommend LESS/SASS solution? Large apps are still going to require a lot of CSS, wondering what is the famous way.
-Thomas
On Jun 23, 2014, at 4:41 PM, Myles Borins notifications@github.com wrote:
Anything that needs to be copied can be added to grunt/copy
I’m trying to figure out how to best handle the import edge case… this is a strange one, as the cache busting could much things up.
On Jun 23, 2014, at 1:40 PM, DrClick notifications@github.com wrote:
Something else that causes us grief is that the cordova files are not put in the dist folder. We have them in the root and access them from the index.js page. Should we be doing something different?
-Thomas
On Jun 23, 2014, at 4:38 PM, Myles Borins notifications@github.com wrote:
Ahhh… I think I know what is going on… give me a couple minutes and a might have a fix / new version of the generator out.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
MylesBorins
commented
10 years ago After going through a number of weird use edge cases I am going to highly suggest to avoid the @import statement inside of css and highly advice adding files to your html index instead. If the files are added inside of specific comment blocks they will automagically get concerted / minified together.
Is there a particular reason for using import other than keeping data out of index?
On Jun 23, 2014, at 1:43 PM, DrClick notifications@github.com wrote:
Is there a recommend LESS/SASS solution? Large apps are still going to require a lot of CSS, wondering what is the famous way.
-Thomas
On Jun 23, 2014, at 4:41 PM, Myles Borins notifications@github.com wrote:
Anything that needs to be copied can be added to grunt/copy
I’m trying to figure out how to best handle the import edge case… this is a strange one, as the cache busting could much things up.
On Jun 23, 2014, at 1:40 PM, DrClick notifications@github.com wrote:
Something else that causes us grief is that the cordova files are not put in the dist folder. We have them in the root and access them from the index.js page. Should we be doing something different?
-Thomas
On Jun 23, 2014, at 4:38 PM, Myles Borins notifications@github.com wrote:
Ahhh… I think I know what is going on… give me a couple minutes and a might have a fix / new version of the generator out.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
DrClick
commented
10 years ago No, as long as it gets merged in the end, I don’t care. Cleaner convention I guess. How should I decorate it in index.html?
-Thomas
On Jun 23, 2014, at 5:25 PM, Myles Borins notifications@github.com wrote:
After going through a number of weird use edge cases I am going to highly suggest to avoid the @import statement inside of css and highly advice adding files to your html index instead. If the files are added inside of specific comment blocks they will automagically get concerted / minified together.
Is there a particular reason for using import other than keeping data out of index?
On Jun 23, 2014, at 1:43 PM, DrClick notifications@github.com wrote:
Is there a recommend LESS/SASS solution? Large apps are still going to require a lot of CSS, wondering what is the famous way.
-Thomas
On Jun 23, 2014, at 4:41 PM, Myles Borins notifications@github.com wrote:
Anything that needs to be copied can be added to grunt/copy
I’m trying to figure out how to best handle the import edge case… this is a strange one, as the cache busting could much things up.
On Jun 23, 2014, at 1:40 PM, DrClick notifications@github.com wrote:
Something else that causes us grief is that the cordova files are not put in the dist folder. We have them in the root and access them from the index.js page. Should we be doing something different?
-Thomas
On Jun 23, 2014, at 4:38 PM, Myles Borins notifications@github.com wrote:
Ahhh… I think I know what is going on… give me a couple minutes and a might have a fix / new version of the generator out.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
MylesBorins
commented
10 years ago Generally import is frowned upon as you are not guaranteeing that resources will load in a non blocking fashion, so it is probably a better practice to avoid import all together when there isn’t a compile step (such as in sass / less)
As far as in index.html, you will notice some comments referencing build such as line 12 - 17
<!-- build:css(app/) css/app.css -->
<link rel="stylesheet" type="text/css" href="styles/app.css" />
<!-- bower:css -->
<!-- endbower -->
<!-- endbuild —>just put the reference below the reference to app, all the files will be concatenated into app in production. On Jun 23, 2014, at 2:27 PM, DrClick notifications@github.com wrote:
No, as long as it gets merged in the end, I don’t care. Cleaner convention I guess. How should I decorate it in index.html?
-Thomas
On Jun 23, 2014, at 5:25 PM, Myles Borins notifications@github.com wrote:
After going through a number of weird use edge cases I am going to highly suggest to avoid the @import statement inside of css and highly advice adding files to your html index instead. If the files are added inside of specific comment blocks they will automagically get concerted / minified together.
Is there a particular reason for using import other than keeping data out of index?
On Jun 23, 2014, at 1:43 PM, DrClick notifications@github.com wrote:
Is there a recommend LESS/SASS solution? Large apps are still going to require a lot of CSS, wondering what is the famous way.
-Thomas
On Jun 23, 2014, at 4:41 PM, Myles Borins notifications@github.com wrote:
Anything that needs to be copied can be added to grunt/copy
I’m trying to figure out how to best handle the import edge case… this is a strange one, as the cache busting could much things up.
On Jun 23, 2014, at 1:40 PM, DrClick notifications@github.com wrote:
Something else that causes us grief is that the cordova files are not put in the dist folder. We have them in the root and access them from the index.js page. Should we be doing something different?
-Thomas
On Jun 23, 2014, at 4:38 PM, Myles Borins notifications@github.com wrote:
Ahhh… I think I know what is going on… give me a couple minutes and a might have a fix / new version of the generator out.
On Jun 23, 2014, at 1:34 PM, DrClick notifications@github.com wrote:
I am doing this: @import url(login.css); where login.css is in the styles folder next to app.css
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
MylesBorins
commented
10 years ago Closing this for now, feel free to re-open if you have more questions :neckbeard:
I found any css files I included with @import are not being compiled in the dist folder. Is this by design? You mentioned something earlier about fonts should be in the sytles/fonts directory. Is there a document I am missing?