search

FamousArchives / generator-famous

for those who hate doing things once
123 stars 26 forks source link

Improvement to index template #41

Closed StephanBijzitter closed 9 years ago

StephanBijzitter commented 10 years ago

UTF-8 encoding will make sure people are not going to have issues with Cyrillic text; minimal-ui will make sure iOS 7 users get a larger viewport with less browser clutter; msapplication-tap-highlight will make sure to remove the disgusting highlights Windows Phone introduces on DOM elements, this to standardise the experience across devices.

StephanBijzitter commented 10 years ago

No idea why Travis is angry with me by the way, I pulled the template from the master branch, added a few lines and boom?

MylesBorins commented 10 years ago

I purposely broke travis on head... heheh There were some broken bits in the code that I hot fixed for the last two releases... just did a major refactor of famous-metrics and I'm patching it up right now.

StephanBijzitter commented 9 years ago

Also fixed the image location in the _main.js template. Previously it only worked in the main directory of a (local) server, now it also works in subdirectories.

MylesBorins commented 9 years ago

I don't think we are going to merge the change from absolute to relative paths. This can be solved either with tooling or with the base tag in the head

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base

AFAIK it is considered best practice to use this style of absolute path.

MylesBorins commented 9 years ago

A better approach would be to implement a generated base path with the html pre-process task that is already running. You can use the grunt config to inject the variable

StephanBijzitter commented 9 years ago

Since HTML 2.0, wow how did I miss this! I'll revert the commit tomorrow at the office :+1:

MylesBorins commented 9 years ago

Closing