FamroFexl / ForceCrawl

Manually control when you crawl.
MIT License
3 stars 1 forks source link

Misplaced configuration file on non-Windows systems #4

Closed val-int1 closed 1 year ago

val-int1 commented 1 year ago

The configuration file gets saved as a file named config\forcecrawl.cfg on non-Windows systems. This is caused by this line which assumes the file separator is a backslash, which (to my knowledge) is a Windows only thing. This can be fixed by replacing the line with either of these:

// This should still work on Windows systems, but might not on some other systems
public static File configFile = new File(FabricLoader.getInstance().getConfigDir() + "/forcecrawl.cfg");
// This ensures using the correct separator on every system
public static File configFile = new File(FabricLoader.getInstance().getConfigDir() + File.separator + "forcecrawl.cfg");
// This uses the fact FabricLoader#getConfigDir() returns a Path object
public static File configFile = FabricLoader.getInstance().getConfigDir().resolve("forcecrawl.cfg").toFile();
Attached is a screenshot of my .minecraft folder ![image](https://github.com/FamroFexl/ForceCrawl/assets/25990664/5a805658-fd36-4eee-9d49-8647617b4efe)

As this does not break the loading/saving of the config, I would understand if it were a low priority issue.

FamroFexl commented 1 year ago

This will be fixed in the next release.