White box around imported sprites - SOR4

FanTranslatorsInternational / Kuriimu2

Kuriimu is a general purpose game translation project manager and toolkit for authors of fan translations and game mods.

GNU General Public License v3.0

314 stars 57 forks source link

White box around imported sprites - SOR4 #104

Closed AyanamiRei1 closed 3 years ago

AyanamiRei1 commented 3 years ago

Streets of Rage 4 Nintendo Switch No extension Image

I've ran into an issue in game the new sprites do work however they have a white box around them like this but this only happens with the character select screen for some reason.

2021-05-01_17-18-27

It seems to due to the Alpha? being different in an original file it's 00 00 00 00

While in an edited file it's 00 FF FF FF but this might be an per image basis since if you reimport the image and then save it's a mix of both the image on the left is the new and right is the original sprite but reimported.

Sample Files https://drive.google.com/drive/folders/1SdbdfUHiMbGZAM34nrQQyCtssOSCoG0f?usp=sharing

onepiecefreak3 commented 3 years ago

I added a premultiply filter in the newest dev build, just like SOR4Explorer does premultiplication.

AyanamiRei1 commented 3 years ago

Perfect its working fine now I'll close this now

AyanamiRei1 commented 3 years ago

Sorry about reopening this but with the SOR4 versions this happens. I was using the batch export and batch import modes.

https://user-images.githubusercontent.com/25233407/116813010-878c1900-ab49-11eb-91b3-fc000d204609.mp4

onepiecefreak3 commented 3 years ago

Batch operations just use the same plugins as single file operations. Since I do premultiplication as the SOR4 Explorer does, I cannot say how this exactly happens. However, at this point I'm inclined to blame the image editing software you use. It may change the transparent colors or something. Whatever it is, without samples, I can't do anything.

AyanamiRei1 commented 3 years ago

Yeah this shouldn't be happening note so far this only happens with edited dxt5 characters. here's the first frame of SOR4 Blaze blaze_0000 00

and here's some samples https://drive.google.com/drive/folders/1SdbdfUHiMbGZAM34nrQQyCtssOSCoG0f?usp=sharing

onepiecefreak3 commented 3 years ago

DXT5 doesn't have the premultiplication, I wonder if that is the cause of this problem. I will add the premultiplication for each encoding and we see if this helps in any way.

onepiecefreak3 commented 3 years ago

The newest dev build has those changes now. Update and try again.

AyanamiRei1 commented 3 years ago

Perfect! Now this issue should stay closed.